[Webkit-unassigned] [Bug 274834] DOMMatrix inverse not the same as SVGMatrix

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=274834

--- Comment #5 from Said Abou-Hallawa <sabouhallawa at apple.com> ---
AffineTransform::inverse() has this check:


    if (!std::isfinite(determinant) || determinant == 0)
        return std::nullopt;


And TransformationMatrix::inverse() has this check:

    if (std::abs(determinant) < SMALL_NUMBER)
        return std::nullopt;

And SMALL_NUMBER is defined as this:

    const double SMALL_NUMBER = 1.e-8;

So I think we can have something between checking if equal to zero and checking if less than SMALL_NUMBER. Maybe something like this:

    if (!std::isnormal(determinant))
        return std::nullopt;

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240529/f11694ec/attachment.htm>