[Webkit-unassigned] [Bug 274796] New: Don't consider 'fill' a presentation attribute on animation elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=274796

            Bug ID: 274796
           Summary: Don't consider 'fill' a presentation attribute on
                    animation elements
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Keywords: BrowserCompat, WPTImpact
          Severity: Normal
          Priority: P2
         Component: SVG
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: sabouhallawa at apple.com, zimmermann at kde.org

Hi Team,

While looking into Safari / WebKit specific failures, I noticed following failure:

Blink Commit: https://chromium-review.googlesource.com/c/chromium/src/+/2080237

WPT Test: https://wpt.fyi/results/svg/styling/presentation-attributes-special-cases.html?label=master&label=experimental&aligned=&q=safari%3Afail

> fill presentation attribute not supported on animate	
> fill presentation attribute not supported on animateMotion
> fill presentation attribute not supported on animateTransform	
> fill presentation attribute not supported on set	

We still fail: fill presentation attribute not supported on discard

___

Add following in SVGSMILElement.cpp:

bool SVGSMILElement::hasPresentationalHintsForAttribute(const QualifiedName& name) const
{
    // Don't map 'fill' to the 'fill' property for animation elements.
    if (name == SVGNames::fillAttr)
        return false;
    return SVGSMILElement::hasPresentationalHintsForAttribute(name);
}

and following in SVGSMILElement.h:

bool hasPresentationalHintsForAttribute(const QualifiedName&) const override;

___

It progresses following tests above. Just wanted to raise so we can fix it.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240528/5f45dcd2/attachment.htm>