[Webkit-unassigned] [Bug 274407] New: check-webkit-style failing for Python changes in WPT

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 20 11:37:01 PDT 2024


https://bugs.webkit.org/show_bug.cgi?id=274407

            Bug ID: 274407
           Summary: check-webkit-style failing for Python changes in WPT
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: gsnedders at apple.com
                CC: jbedard at apple.com, karlcow at apple.com,
                    webkit-bug-importer at group.apple.com

Karl hit the following:

```
% git webkit pr            
>From github.com:WebKit/WebKit
 * branch                      main       -> FETCH_HEAD
Current branch 274304-wpt-html-canvas is up to date.
ERROR: Unexpected diff format when parsing a chunk: '100" height="
'
ERROR: Unexpected diff format when parsing a chunk: '100"><p class="fallback">FAIL (fallback content)</p></canvas>'
ERROR: LayoutTests/imported/w3c/web-platform-tests/html/canvas/tools/gentestutilsunion.py:386:  too many blank lines (2)  [pep8/E303] [5]
ERROR: LayoutTests/imported/w3c/web-platform-tests/html/canvas/tools/gentestutilsunion.py:484:  continuation line with same indent as next logical line  [pep8/E125] [5]
ERROR: LayoutTests/imported/w3c/web-platform-tests/html/canvas/tools/gentestutilsunion.py:580:  continuation line over-indented for hanging indent  [pep8/E126] [5]
Total errors found: 3 in 1020 files
style-checker failed, continue uploading pull request?
Retry will amend the commit with your changes. (Yes/Retry/[No]): 
```

This is surprising given on the face of it we should be ignoring all of LayoutTests, per https://github.com/WebKit/WebKit/blob/87181326e4b98e672a0cb51872cb55f7f0dd0ae3/Tools/Scripts/webkitpy/style/checker.py#L478

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240520/984df467/attachment.htm>


More information about the webkit-unassigned mailing list