[Webkit-unassigned] [Bug 274266] REGRESSION (278817 at main): [ MacOS iOS Debug ] TestWebKitAPI.AdvancedPrivacyProtections.AddNoiseToWebAudioAPIs is a consistent failure

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=274266

--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Oh, I see — this is hitting a debug-only assertion that we shouldn't be fast-mallocing, seemingly because:

1. The noise injection mechanism now allocates some amount of memory in the process of mapping all equal values to the same noisy value.

2. There's some logic in web audio code that uses `ForbidMallocUseForCurrentThreadScope` to enforce no allocations, for performance reasons.

Since this codepath is only triggered for private browsing and we already take a slight performance hit for noise injection before these mitigations, I think it's safe to deploy a `DisableMallocRestrictionsForCurrentThreadScope` here to suppress the debug assertion.

--- Comment #4 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Oh, I see — this is hitting a debug-only assertion that we shouldn't be fast-mallocing, seemingly because:

1. The noise injection mechanism now allocates some amount of memory in the process of mapping all equal values to the same noisy value.

2. There's some logic in web audio code that uses `ForbidMallocUseForCurrentThreadScope` to enforce no allocations, for performance reasons.

Since this codepath is only triggered for private browsing and we already take a slight performance hit for noise injection before these mitigations, I think it's safe to deploy a `DisableMallocRestrictionsForCurrentThreadScope` here to suppress the debug assertion.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240517/d69614a7/attachment.htm>