[Webkit-unassigned] [Bug 247980] WebKitGTK seems confused about size of 1px on 283 dpi display

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=247980

--- Comment #25 from Michael Catanzaro <mcatanzaro at redhat.com> ---
This also introduced bug #274083 ("Sides of buttons are cut off on GitLab") which I incorrectly blamed on Skia. I do not know what's wrong with the buttons.

(In reply to Glen Whitney from comment #24)
> I wasn't sure how to differentiate the screen type, nor of the extent to which WebKitGTK expected to produce ideal results on a mobile device;

It's expected to work on both mobile and desktop. hostnamed has a chassis type field that can be used to detect mobile devices; however, it's not accessible in the web process sandbox, so we'd need to create a chassis type portal to access it. It's probably better to avoid altering behavior based on chassis type and instead change the behavior based on screen size instead. (Normally I would say "window size" rather than screen size, but for the purposes of this issue, sounds like screen size is really what matters.)

> (3) Finally, I would of course like the opportunity to make a revised PR to
> resolve this issue, and clearly it would need to be one that does not cause
> the difficulties referred to in issue
> https://bugs.webkit.org/show_bug.cgi?id=274075  -- however, there is not any
> detail in that issue: it simply states "Broke font rendering in some cases"
> but does not give any information as to what cases or how to reproduce or
> how to know what is correct font rendering in these cases or how to test.

I've also asked for more info here, but so far all I've heard is "too big" which is not very precise. I haven't noticed any size changes myself other than the issue with the buttons.

If Firefox and Chrome behave consistently, then it'd be pragmatic to match whatever they do.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240513/180beb50/attachment.htm>