[Webkit-unassigned] [Bug 274011] New: Fix RenderTreeBuilder::move() to clear percent height map

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=274011

            Bug ID: 274011
           Summary: Fix RenderTreeBuilder::move() to clear percent height
                    map
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Keywords: BrowserCompat
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: bfulgham at webkit.org, simon.fraser at apple.com,
                    zalan at apple.com

Hi Team,

While looking into old Blink's commit, I came across another failing test case:

Test Case - https://jsfiddle.net/nqt0g1yz/

^ Does not show 'blue' box in Safari / WebKit ToT while does show in Chrome Canary 126 and Firefox Nightly 127.

Blink Commit - https://chromium.googlesource.com/chromium/src.git/+/7afb0474da50c93fa2360fc70ccbb73a313a45f7

WebKit Source: https://searchfox.org/wubkat/rev/5169139ac1127c419017b37d9f2106a2c199070f/Source/WebCore/rendering/updating/RenderTreeBuilder.cpp#489 , https://searchfox.org/wubkat/rev/5169139ac1127c419017b37d9f2106a2c199070f/Source/WebCore/rendering/updating/RenderTreeBuilder.cpp#545 and https://searchfox.org/wubkat/rev/5169139ac1127c419017b37d9f2106a2c199070f/Source/WebCore/rendering/RenderBlock.cpp#832

___

I did following changes and it compiles and progress following:

> RenderTreeBuilder::move() 

if (normalizeAfterInsertion == NormalizeAfterInsertion::Yes && is<RenderBlock>(from) && child.isRenderBox())
        RenderBlock::removePercentHeightDescendantIfNeeded(downcast<RenderBox>(child));

and

> RenderTreeBuilder::moveChildren() - Line 549

RenderBlock::removePercentHeightDescendantIfNeeded(*blockFlow);

and

RenderBlock::dirtyForLayoutFromPercentageHeightDescendants()

ASSERT(renderer->isDescendantOf(this));

___

Just raising so we can fix it.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240510/583ab92a/attachment.htm>