[Webkit-unassigned] [Bug 273975] New: [WPE][GTK] createNewPage in WebKitUIClient.cpp needs some hooking up of the API::PageConfiguration

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=273975

            Bug ID: 273975
           Summary: [WPE][GTK] createNewPage in WebKitUIClient.cpp needs
                    some hooking up of the API::PageConfiguration
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKitGTK
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at redhat.com
                CC: achristensen at apple.com, bugs-noreply at webkitgtk.org

On webkit-dev@, Alex writes:

"createNewPage in WebKitUIClient.cpp needs some hooking up of the API::PageConfiguration in a way I couldn’t figure out in the few minutes I looked at it.  This should be pretty straightforward to someone who knows the glib code better than I do."

I'm going to propose a pull request to unblock this, but I have a question. In webkitWebContextCreatePageForWebView, we need to take many settings from the related view's configuration, because this is an API guarantee. Presumably the new API::Configuration object is expected to match the related view, so it's probably not a problem, but this does mean we won't respect all of the values set in the API::Configuration in case they are different for some reason. Specifically:

    pageConfiguration->setProcessPool(context->priv->processPool.get());
    pageConfiguration->setPreferences(webkitSettingsGetPreferences(webkit_web_view_get_settings(webView)));
    pageConfiguration->setRelatedPage(relatedView ? &webkitWebViewGetPage(relatedView) : nullptr);
    pageConfiguration->setUserContentController(userContentManager ? webkitUserContentManagerGetUserContentControllerProxy(userContentManager) : nullptr);
    pageConfiguration->setControlledByAutomation(webkit_web_view_is_controlled_by_automation(webView));

All those will get overridden. I *assume* this is OK.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240509/5a320ce9/attachment.htm>