[Webkit-unassigned] [Bug 273792] REGRESSION(276079 at main): [GTK] Web view content disappears after back/forward navigation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=273792

Michael Catanzaro <mcatanzaro at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vitaly at igalia.com
            Summary|REGRESSION(2.44): [GTK] Web |REGRESSION(276079 at main):
                   |view content disappears     |[GTK] Web view content
                   |after back/forward          |disappears after
                   |navigation                  |back/forward navigation

--- Comment #2 from Michael Catanzaro <mcatanzaro at redhat.com> ---
OK, here is the bisect result. But note that the way in which this is broken changed at some point between here and now. Currently when you press Back, you go to a solid black web view. But as of the first bad commit, you go to back to a transparent web view. Something changed later on to change it from transparent to black. I should be able to bisect that if needed, but I'll assume it's not needed unless requested.


7c138c89f181e0a39ee64cd986ef11a848793575 is the first bad commit
commit 7c138c89f181e0a39ee64cd986ef11a848793575
Author: Vitaly Dyachkov <vitaly at igalia.com>
Date:   Thu Mar 14 02:18:59 2024 -0700

    [CoordinatedGraphics] Setting `LocalFrameView`'s content size should not require relayout
    https://bugs.webkit.org/show_bug.cgi?id=270445

    Reviewed by Darin Adler.

    In `LocalFrameViewLayoutContext::performLayout()` we layout the render
    tree in several phases:

    - `LayoutPhase::InPreLayout`
    - `LayoutPhase::InRenderTreeLayout`
    - `LayoutPhase::InViewSizeAdjust`
    - `LayoutPhase::InPostLayout`

    In the last phase, we assert that the layout root doesn't require
    relayout after updating `LocalFrameView`'s content size.

    Currently, at the end of `LayerTreeHost::contentsSizeChanged()` we call
    `didChangeViewport()`, which in some circumstances (e.g. when fixed
    layout is used) can trigger
    `LocalFrameView::setViewportConstrainedObjectsNeedLayout()` and make
    `RenderView::needsLayout()` return `true`. This should not happen.

    * Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp:
    (WebKit::LayerTreeHost::contentsSizeChanged):

    Canonical link: https://commits.webkit.org/276079@main

 Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp | 1 -
 1 file changed, 1 deletion(-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240507/b112a35f/attachment-0001.htm>