[Webkit-unassigned] [Bug 123464] Node shouldn't be selected if it's not a draggable element and has -webkit-user-select: none set
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 3 16:42:13 PDT 2024
https://bugs.webkit.org/show_bug.cgi?id=123464
Ahmad Saleem <ahmad.saleem792 at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ahmad.saleem792 at gmail.com
--- Comment #4 from Ahmad Saleem <ahmad.saleem792 at gmail.com> ---
This patch was modifying this:
https://searchfox.org/wubkat/rev/3f1a725ef3d3f0a0ee05b56aff41fbfdae90f34f/Source/WebCore/dom/Node.cpp#1288
- It seems blink did the change:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/dom/node.cc;l=1654;drc=5180d4deb2bee0cc22d14ced5ac540e51135a2e5
** Blink:
// We allow selections to begin within |user-select: text/all| sub trees
// but not if the element is draggable.
if (style.UserDrag() != EUserDrag::kElement &&
(user_select == EUserSelect::kText || user_select == EUserSelect::kAll))
return true;
** WebKit:
// We allow selections to begin within an element that has -webkit-user-select: none set,
// but if the element is draggable then dragging should take priority over selection.
if (style.userDrag() == UserDrag::Element && style.usedUserSelect() == UserSelect::None)
return false;
}
__
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240503/82a3d5a3/attachment.htm>
More information about the webkit-unassigned
mailing list