[Webkit-unassigned] [Bug 273235] REGRESSION(277673 at main+): -ref.html files are no longer imported

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=273235

--- Comment #2 from Sam Sneddon [:gsnedders] <gsnedders at apple.com> ---
>From the old code:

```
    def is_reference_filename(self):
        # From tools/manifest/sourcefile.py in WPT repository
        # https://github.com/web-platform-tests/wpt/blob/22f29564bb82b407aeaf6507c8efffdbd51b9974/tools/manifest/sourcefile.py#L405
        reference_file_re = re.compile(r'(^|[\-_])(not)?ref[0-9]*([\-_]|$)')
        return "/reference/" in self.filename or bool(reference_file_re.search(self.filename))
```

(Introduced in bug 234510)

The WPT code this is copied from has the filename without the extension at this point, which means it matches `foo-ref` but not `foo-ref.html`; as such, we concluded `foo-ref.html` wasn't a reference and imported it as a support file. *However* we do correctly check for `/reference/`, so we do sometimes exclude the original filename.

This was arguably a bug in the prior patch, as it was only after that we started importing both `-ref.html` and `-expected.html`.

So we've got two questions here:

1. What is the correct behaviour? Should we be importing both -ref.html and -expected.html? (Probably yes — in the git world this doesn't bloat the repo as the files are identical.)
2. If we want to import `-ref.html`, do we *also* want to import files in `reference`? (Probably also yes — the inconsistency is the weirdest part of this!)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240502/84798634/attachment.htm>