[Webkit-unassigned] [Bug 271716] Port.default_child_processes is totally ignored for second-and-later device_types, even when zero

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 26 12:06:33 PDT 2024


Sam Sneddon [:gsnedders] <gsnedders at apple.com> changed:

           What    |Removed                     |Added
            Summary|Second-and-later            |Port.default_child_processe
                   |device_types are never      |s is totally ignored for
                   |skipped                     |second-and-later
                   |                            |device_types, even when
                   |                            |zero

--- Comment #1 from Sam Sneddon [:gsnedders] <gsnedders at apple.com> ---
I guess this only actually has broken anything when Port.default_child_processes() is zero and Port.max_child_processes() is not, which I think never actually happens for any existing Port.

Regardless, it adds very much a confusing edge-case in our code flow, and the comment is misleading: it has no impact on retries (we already hardcoded num_workers=1 in _run_test_subset).

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240326/d0fad9a5/attachment.htm>

More information about the webkit-unassigned mailing list