[Webkit-unassigned] [Bug 125399] Make indent command to work with positional CSS selector, e.g. :first-child, with visibility

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125399

--- Comment #9 from Ahmad Saleem <ahmad.saleem792 at gmail.com> ---
(In reply to Ahmad Saleem from comment #8)
> Just to add this patch seems to be got undone by following Blink commit:
> 
> https://chromium.googlesource.com/chromium/blink/+/
> 0cd4b3864db4fc9c0abfeeee0775c5fcbbca0184

Merging this:

```

// We should clone all the children of the list item for indenting purposes. However, in case the current
    // selection does not encompass all its children, we need to explicitally handle the same. The original
    // list item too would require proper deletion in that case.
    if (end.anchorNode() == selectedListItem.get() || end.anchorNode()->isDescendantOf(selectedListItem->lastChild()))
        moveParagraphWithClones(start, end, newList.get(), selectedListItem.get());
    else {
        moveParagraphWithClones(start, positionAfterNode(selectedListItem->lastChild()), newList.get(), selectedListItem.get());
        removeNode(*selectedListItem);
    }

```

leads to one WPT progression and matching with Blink / Chromium:

> https://wpt.fyi/results/editing/run/indent.html?label=master&label=experimental&aligned=&q=indent.html

This one:

>> [["indent",""]] "<ol><li>[foo]<br>bar<li>baz</ol>" compare innerHTML	

This one is passing in other browsers while failing only in WebKit / Safari - so it would be good to merge this and align with others: https://wpt.fyi/results/editing/run/indent.html?label=master&label=experimental&aligned=&q=safari%3Afail+chrome%3Apass+firefox%3Apass

Any thoughts?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240325/7da16fd0/attachment.htm>