[Webkit-unassigned] [Bug 271190] New: Remove unused `width()` and `height()`functions from HTMLDocument (WebKit and WebKitLegacy)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 18 15:49:13 PDT 2024


            Bug ID: 271190
           Summary: Remove unused `width()` and `height()`functions from
                    HTMLDocument (WebKit and WebKitLegacy)
           Product: WebKit
           Version: Safari Technology Preview
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: DOM
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com

Hi Team,

It seems we dropped them in 2016 from JS exposure and we don't have them in IDL file as of today but we still have C++ code, so I think we should just do the clean-up and get rid of it.

Commit (from 2016 to drop them) - https://github.com/WebKit/WebKit/commit/aabd1dae8c07814a8c27cd98575cf473fc556eac

> Source/WebCore/html/HTMLDocument.cpp:

Delete: HTMLDocument::width()

Delete: HTMLDocument::height()

> Source/WebCore/html/HTMLDocument.h:

WEBCORE_EXPORT int width();
WEBCORE_EXPORT int height();

> Source/WebKitLegacy/mac/DOM/DOMHTMLDocument.mm:

- (int)width --> return NULL;
- (int)height --> return NULL;


Just wanted to raise so we can do the clean-up.


You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240318/70b513be/attachment-0001.htm>

More information about the webkit-unassigned mailing list