[Webkit-unassigned] [Bug 271123] New: WebSocketHandshake::readHTTPHeaders should return the number of consumed bytes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 17 01:13:06 PDT 2024


https://bugs.webkit.org/show_bug.cgi?id=271123

            Bug ID: 271123
           Summary: WebSocketHandshake::readHTTPHeaders should return the
                    number of consumed bytes
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: New Bugs
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: annevk at annevk.nl

hi Team,

Just another potential partial merge (only WebSocket): https://src.chromium.org/viewvc/blink?view=revision&revision=175630

Blink Commit:

`Currently parseHTTPHeaders returns (the number of consumed bytes - x) where
 - x = 0 if it consumes an empty line
 - x = 1 otherwise
This CL make parseHTTPHeaders always return the number of consumed bytes.`

____

WebKit Source: https://searchfox.org/wubkat/rev/c7c814d5a000eb37da1d6bd0e4e634f9fc85887e/Source/WebCore/Modules/websockets/WebSocketHandshake.cpp#441

Changing to `while (p < end) {` works and compile.


Just wanted to raise to get input, if we need to do this change.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240317/f020ebc8/attachment.htm>


More information about the webkit-unassigned mailing list