[Webkit-unassigned] [Bug 271122] New: WebSocket must not be established when subprotocol is not selected by the server

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=271122

            Bug ID: 271122
           Summary: WebSocket must not be established when subprotocol is
                    not selected by the server
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: New Bugs
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: annevk at annevk.nl, ysuzuki at apple.com

Hi Team,

While going through Blink's commit, I came across one from @yusuke and noticed that we have merged this or tackle this:

Blink Commit: https://src.chromium.org/viewvc/blink?view=revision&revision=155603

WebKit Source: https://searchfox.org/wubkat/rev/c7c814d5a000eb37da1d6bd0e4e634f9fc85887e/Source/WebCore/Modules/websockets/WebSocketHandshake.cpp#532

^ Bit below but from here, it starts and below compiles:

        } else if (!m_clientProtocol.isEmpty()) {
            m_failureReason = "Error during WebSocket handshake: Sec-WebSocket-Protocol mismatch"_s;
            return false;
        }

__

Unfortunately, testing `http` tests is not something I know on how to do locally. So just raising to get input.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240317/1405eb11/attachment-0001.htm>