[Webkit-unassigned] [Bug 271108] REGRESSION(274077 at main): failure to build on i586 (and likely other 32bit arches): static assertion failed: Timer should stay small

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 16 17:45:11 PDT 2024


https://bugs.webkit.org/show_bug.cgi?id=271108

--- Comment #3 from Michael Catanzaro <mcatanzaro at redhat.com> ---
Hey Ryosuke, are you OK with this? I will create a pull request soon.

(Alternatively, we could put the uint8_t at the bottom of the struct by reordering the Timer data members.)

diff --git a/Source/WebCore/platform/Timer.cpp b/Source/WebCore/platform/Timer.cpp
index 4f7c0f5c39ca..0f3734cca247 100644
--- a/Source/WebCore/platform/Timer.cpp
+++ b/Source/WebCore/platform/Timer.cpp
@@ -263,7 +263,11 @@ struct SameSizeAsTimer {

     WeakPtr<TimerAlignment> timerAlignment;
     double times[2];
-    void* pointers[3];
+    void* pointers[2];
+#if CPU(ADDRESS32)
+    uint8_t bitfields;
+#endif
+    void* pointer;
 };

 static_assert(sizeof(Timer) == sizeof(SameSizeAsTimer), "Timer should stay small");

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240317/69a74113/attachment.htm>


More information about the webkit-unassigned mailing list