[Webkit-unassigned] [Bug 271014] New: [style-checker] Conflicting rules about include ordering -- mixing system/custom headers and including Softlink.h headers after all other headers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=271014

            Bug ID: 271014
           Summary: [style-checker] Conflicting rules about include
                    ordering -- mixing system/custom headers and including
                    Softlink.h headers after all other headers
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: a_protyasha at apple.com
                CC: a_protyasha at apple.com,
                    webkit-bug-importer at group.apple.com

On this PR, I am getting a style-checker error that I'm not sure how to address. It looks like there is a conflict between two include ordering rules:

1. Bad include order. Mixing system and custom headers.  [build/include_order] [4]
2. *SoftLink.h header should be included after all other headers.  [build/include_order] [4]

I settled for surfacing error (1) in the PR because (2) could actually have correctness issues, but at any rate, style-checker will always return this "bad include order" error if (a) I try to include all related Softlink.h headers after all other headers and (b) I have a mix of system and custom headers to include for softlinking.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240314/cefdb6ca/attachment.htm>