[Webkit-unassigned] [Bug 270776] New: [Skia] libSkia.a is always considered outdated

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 10 19:03:55 PDT 2024


https://bugs.webkit.org/show_bug.cgi?id=270776

            Bug ID: 270776
           Summary: [Skia] libSkia.a is always considered outdated
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WPE WebKit
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: pgriffis at igalia.com
                CC: bugs-noreply at webkitgtk.org
            Blocks: 268972

If you run: `ninja -d explain -C WebKitBuild/WPE/Debug libSkia.a`

It outputs:

    ninja explain: output Source/ThirdParty/skia/CMakeFiles/Skia_headers_symlink doesn't exist
    ninja explain: Source/ThirdParty/skia/CMakeFiles/Skia_headers_symlink is dirty
    ninja explain: Skia/Headers/skia is dirty
    [1/1] Link Skia headers

This causes every single build to relink Skia and everything that depends on it.

Currently this is defined in CMake as:

    add_custom_target(Skia_headers_symlink
        COMMAND ${CMAKE_COMMAND} -E create_symlink
            "${CMAKE_CURRENT_SOURCE_DIR}/include"
            "${Skia_FRAMEWORK_HEADERS_DIR}/skia"
        BYPRODUCTS
            "${Skia_FRAMEWORK_HEADERS_DIR}/skia"
        COMMENT "Link Skia headers"
    )
    add_dependencies(Skia Skia_headers_symlink)

I'm not sure what the proper solution to this is.


Referenced Bugs:

https://bugs.webkit.org/show_bug.cgi?id=268972
[Bug 268972] [META][GLib] ☂️ Adopt Skia for painting
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240311/9cf6746c/attachment-0001.htm>


More information about the webkit-unassigned mailing list