[Webkit-unassigned] [Bug 270757] New: Do not run the references when a test crashes or times out

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 9 16:21:31 PST 2024


https://bugs.webkit.org/show_bug.cgi?id=270757

            Bug ID: 270757
           Summary: Do not run the references when a test crashes or times
                    out
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: ap at webkit.org, gsnedders at apple.com, jbedard at apple.com,
                    ryanhaddad at apple.com

Hi Team,

While going through Blink's commit, I came across this optimization for test suite but don't know whether we have done similar in one way or shape but just wanted to raise to get input.

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/a7ba83f0e6c7c9c1ebcab9ea4f53e899b26c397e

WebKit Source: https://searchfox.org/wubkat/rev/93c3eb8ac99a6b6e3894deaf14e5d38304898b48/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py#354

and

https://searchfox.org/wubkat/rev/93c3eb8ac99a6b6e3894deaf14e5d38304898b48/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py#378

__

Blink Commit Details:

If the actual test in a reftest crashes or times out, we probably shouldn't
bother executing the reference as well, since we have nothing
to compare it to, and the test failed regardless. This can save
a bunch of execution time and avoid some confusion.

__

Just raising to get input.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240310/048f9869/attachment.htm>


More information about the webkit-unassigned mailing list