[Webkit-unassigned] [Bug 270595] New: Web Inspector: FolderizedTreeElement doesn't need to remember expansion states anymore since FolderTreeElement already does the job

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 6 12:50:17 PST 2024


https://bugs.webkit.org/show_bug.cgi?id=270595

            Bug ID: 270595
           Summary: Web Inspector: FolderizedTreeElement doesn't need to
                    remember expansion states anymore since
                    FolderTreeElement already does the job
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: All
                OS: All
            Status: NEW
          Severity: Enhancement
          Priority: P2
         Component: Web Inspector
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: qianlangchen at apple.com
                CC: inspector-bugzilla-changes at group.apple.com

In the inspector's frontend, the FolderizedTreeElement component currently has the duty of listening to its child FolderTreeElement's change of expanded state and recording that with a local WI.Setting. (See https://github.com/WebKit/WebKit/blob/c31beeb0aa293d11b9d23a4c6f2f70cfda461dbe/Source/WebInspectorUI/UserInterface/Views/FolderizedTreeElement.js#L310-L318)

The PR https://github.com/WebKit/WebKit/pull/25370 adds this recording functionality to FolderTreeElement directly, which is used in a few more places in the inspector's frontend (like in the Storage tab).

So, FolderizedTreeElement no longer needs to have that duty anymore, and all it needs to do is pass the id of the tree element to its child FolderTreeElement to let it do the recording job.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240306/7e1800d1/attachment.htm>


More information about the webkit-unassigned mailing list