[Webkit-unassigned] [Bug 270489] New: Add PR reference when closing a bug on webkit.org

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=270489

            Bug ID: 270489
           Summary: Add PR reference when closing a bug on webkit.org
           Product: WebKit
           Version: Safari 17
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: karlcow at apple.com

*Steps To Reproduce:*
I do not know what are the steps to reproduce but…
If `git-webkit pr` fails to comment on the bug or the contributor files the PR without git-webkit, there is no reference to the PR in GitHub. 

This is an example:
https://bugs.webkit.org/show_bug.cgi?id=268825

There is the final EWS message
```
EWS 2024-02-16 02:40:01 PST
Committed 274814 at main (9ce832dcb0d3): <https://commits.webkit.org/274814@main>

Reviewed commits have been landed. Closing PR #23960 and removing active labels.
```

But then no link to a PR
https://github.com/WebKit/WebKit/pull/23960

The link to the PR is given by the UI in GitHub inside the commit link, but I didn’t know it existed before someone pointed it to me. 

*Why this is important?*

PR contains important information, rationales, discussions, etc about the bug through the comments on the PR. These are not reflected anywhere but on GitHub only (it’s already a weak scenario).

Having the link to the PR is very practical to directly find the history of review and discussions. 

*Suggestion*:

Extend the final EWS message to also have a link to the PR in addition to the commit link.

The text is already here `Closing PR #23960`. This could be a link.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240305/6be51165/attachment.htm>