[Webkit-unassigned] [Bug 250946] Reduce calls to LayoutUnit(int) in RenderBox.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=250946

--- Comment #2 from Ahmad Saleem <ahmad.saleem792 at gmail.com> ---
This does not compile:

    struct ComputedMarginValues {
 +      ComputedMarginValues() { }

        LayoutUnit m_before;
        LayoutUnit m_after;
        LayoutUnit m_start;
        LayoutUnit m_end;
    };
    struct LogicalExtentComputedValues {
 +      LogicalExtentComputedValues() { }

        LayoutUnit m_extent;
        LayoutUnit m_position;
        ComputedMarginValues m_margins;
    };

___

no matching constructor for initialization of
      'RenderBox::LogicalExtentComputedValues'
  ...{ static_cast<int>(roundf(m_viewport.height())), logicalTop, ComputedMarginValues() };
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

___

Looking into 'LogicalExtentComputedValues()' - I don't see any calls, while I do see for 'ComputedMarginValues()'.

@Alan - do we need this or we can close this bug?

__

With this change, it does compile:

struct ComputedMarginValues {
+       ComputedMarginValues() { }


        LayoutUnit m_before;
        LayoutUnit m_after;
        LayoutUnit m_start;
        LayoutUnit m_end;
    };

___

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240304/ffde042d/attachment-0001.htm>