[Webkit-unassigned] [Bug 275368] WKWebsiteDataStore thread assertions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 13 10:41:42 PDT 2024


https://bugs.webkit.org/show_bug.cgi?id=275368

--- Comment #5 from Adam Lickel <adam at lickel.com> ---
> Can you clarify what you meant by "the auto-generated Swift Concurrency methods"?
>
> I believe WebKit's @MainActor annotations (present in main but not in the Seed 1 SDK) address the issue reported here. But I'm trying to figure out if other parts of the SDK may have issues.

I agree, except maybe the assertion that occurs in AppDelegate.appDidFinishLaunching() which was still crashing when the call was made on the Main Thread.

> There's no need for any of this surrounding async-ifying code. 

The intention was to delete all of these things in “parallel” rather than iteratively dispatching requests. 

My assumption is it works roughly as:
* get file on main thread
* off main thread delete the File object
* return status on main thread

If I perform this in parallel then the N File deletions could occur simultaneously.

If the underlying File IO will be performed iteratively in a single threaded queue, then I will remove the Task Group.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240613/faf50cfc/attachment.htm>


More information about the webkit-unassigned mailing list