[Webkit-unassigned] [Bug 275174] The URL for Chromium bugs has changed, stopping them from being added to See Also in Bugzilla

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=275174

--- Comment #3 from Daniel Jacobs <danielhunterjacobs at gmail.com> ---
Maybe the subroutines in https://github.com/WebKit/WebKit/blob/main/Websites/bugs.webkit.org/Bugzilla/BugUrl/Chromium.pm should just be these, adapted from the simpler code in https://github.com/WebKit/WebKit/blob/main/Websites/bugs.webkit.org/Bugzilla/BugUrl/Google.pm. Though if there's still a desire to support the old Chromium URL syntax the code would either need to be more complex or these subroutines could be added to a new Perl module. I just don't understand the point of the current code for Chromium that gets $project_name and $bug_id in _check_value.

sub should_handle {
    my ($class, $uri) = @_;

    # Chromium URLs have this form:
    #   http(s)://issues.chromium.org/issues/1234
    return (lc($uri->authority) eq 'issues.chromium.org'
            and $uri->path =~ m|^/issues/\d+$| ? 1 : 0;
}

sub _check_value {
    my ($class, $uri) = @_;

    $uri = $class->SUPER::_check_value($uri);

    return $uri;
}

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240606/b2003d23/attachment.htm>