[Webkit-unassigned] [Bug 275134] New: Enable GraphicsContext filters for Canvas filter

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 4 16:26:24 PDT 2024


https://bugs.webkit.org/show_bug.cgi?id=275134

            Bug ID: 275134
           Summary: Enable GraphicsContext filters for Canvas filter
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: sabouhallawa at apple.com
                CC: bfulgham at webkit.org, simon.fraser at apple.com,
                    zalan at apple.com

GraphicsContext filters were disabled for the canvas filter in 278000 at main. The canvas drop-shadow filter was drawn upside down. So software filters were used instead to make the layout test pass.

It turned out all we need is to flip the sign of the vertical offset of the drop-shadow. This is what CanvasRenderingContext2DBase::applyShadow() does when it sets GraphicsContext drop-shadow by calling:

    c->setDropShadow({ { width, -height }, state().shadowBlur, state().shadowColor, ShadowRadiusMode::Legacy });

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240604/c765b825/attachment.htm>


More information about the webkit-unassigned mailing list