[Webkit-unassigned] [Bug 258219] [Wasm-GC] Add support for bottom heap types

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=258219

David Degazio <d_degazio at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
                 CC|                            |d_degazio at apple.com
             Status|NEW                         |RESOLVED

--- Comment #3 from David Degazio <d_degazio at apple.com> ---
As far as I can tell, the encoding here has actually changed since this bug was opened, and the attached WASM binary is no longer valid. Specifically, it has the following sequence:

    d065 ;; ref.null none
    1a
    d069 ;; ref.null nofunc
    1a
    d068 ;; ref.null noextern
    1a

Specifically using 0x65, 0x69, and 0x68 to represent heap types none, nofunc, and noextern respectively. Per the current GC proposal spec though (https://webassembly.github.io/gc/core/binary/types.html#binary-heaptype), these should actually be encoded as 0x71, 0x73, and 0x72. Recompiling the attached test.wat with wasm-as version 118 produces a different binary with these new heaptypes, which JSC seems to handle without issue.

So, support for none, nofunc, and noextern is working as expected, and I'll resolve this as a dupe of Asumu's other bug.

*** This bug has been marked as a duplicate of bug 254695 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240730/32af5f8c/attachment.htm>