[Webkit-unassigned] [Bug 276734] New: [JSC] Debug build fails to compile when JIT_OPERATION_VALIDATION is disabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=276734

            Bug ID: 276734
           Summary: [JSC] Debug build fails to compile when
                    JIT_OPERATION_VALIDATION is disabled
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Trivial
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: marcus_plutowski at apple.com

rdar://131950848
If you try to compile JSC in debug with JIT_OPERATION_VALIDATION forced to 0, some portions of the feature still compile (and therefore throw errors) because JIT_OPERATION_VALIDATION_ASSERT_ENABLED currently only checks ASSERT_ENABLED.
At one point it was gated by ENABLE(JIT_OPERATION_VALIDATION), so this was not the case, but since then that gate was weakened and changed to `#if ENABLE(JIT_OPERATION_VALIDATION) || ENABLE(JIT_OPERATION_DISASSEMBLY)`. As such, JIT_OPERATION_VALIDATION_ASSERT_ENABLED should explicitly check for JIT_OPERATION_VALIDATION to ensure it’s not turned on when not requested.
This is helpful for debugging.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240717/6dc81fdb/attachment.htm>