[Webkit-unassigned] [Bug 268510] New: webkitpy/layout_tests/models/test_run_results_unittest.py can be very slow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=268510

            Bug ID: 268510
           Summary: webkitpy/layout_tests/models/test_run_results_unittest
                    .py can be very slow
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: gsnedders at apple.com
                CC: jbedard at apple.com

A bunch of these are by far the slowest tests in layout_tests:

14.09s call     layout_tests/models/test_run_results_unittest.py::SummarizedResultsTest::test_summarized_results_world_leaks_disabled
14.05s call     layout_tests/models/test_run_results_unittest.py::SummarizedResultsTest::test_summarized_run_metadata
14.03s call     layout_tests/models/test_run_results_unittest.py::SummarizedResultsTest::test_git_revision_exists
14.03s call     layout_tests/models/test_run_results_unittest.py::SummarizedResultsTest::test_summarized_results_wontfix
14.00s call     layout_tests/models/test_run_results_unittest.py::SummarizedResultsTest::test_summarized_results_include_passes

Unit tests that take that long to run are *painful*.

This time is almost entirely within webkitpy/port/base.py:1471(commits_for_upload), because this ultimately ends up calling `git branch --contains [HEAD] -a`, which on a WebKit tree with large numbers of remotes is *slow*.

Almost none of these tests actually care about revision *at all*, so just using a mock should be fine here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240201/63379fb0/attachment.htm>