[Webkit-unassigned] [Bug 267180] [SVG2] Add support for the 'turn' unit in <angle>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=267180

Karl Dubost <karlcow at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |BrowserCompat
                 CC|                            |annevk at annevk.nl,
                   |                            |heycam at apple.com,
                   |                            |webkit-bug-importer at group.a
                   |                            |pple.com

--- Comment #1 from Karl Dubost <karlcow at apple.com> ---
SVG2 Draft
https://svgwg.org/svg2-draft/types.html#InterfaceSVGAngle

There is a sentence about 
https://svgwg.org/svg2-draft/types.html#__svg__SVGAngle__SVG_ANGLETYPE_UNKNOWN

> For example, for an <angle> with a turn unit, SVG_ANGLETYPE_UNKNOWN would be returned.

At the same time, there is link to https://www.w3.org/TR/css-values/#angles
which defines turn as a possible value.


It creates something bizarre where 
Source/WebCore/svg/SVGAngleValue.h would be

class SVGAngleValue {
    WTF_MAKE_FAST_ALLOCATED;
public:
    enum Type {
        SVG_ANGLETYPE_UNKNOWN = 0,
        SVG_ANGLETYPE_UNSPECIFIED = 1,
        SVG_ANGLETYPE_DEG = 2,
        SVG_ANGLETYPE_RAD = 3,
        SVG_ANGLETYPE_GRAD = 4,
        SVG_ANGLETYPE_TURN = 5
    };


and Source/WebCore/svg/SVGAngle.idl would be

[
    ConstantsScope=SVGAngleValue,
    Exposed=Window
] interface SVGAngle {
    // Angle Unit Types
    const unsigned short SVG_ANGLETYPE_UNKNOWN = 0;
    const unsigned short SVG_ANGLETYPE_UNSPECIFIED = 1;
    const unsigned short SVG_ANGLETYPE_DEG = 2;
    const unsigned short SVG_ANGLETYPE_RAD = 3;
    const unsigned short SVG_ANGLETYPE_GRAD = 4;


Let's ask Cameron or Anne


It doesn't really address the question directly
https://github.com/w3c/svgwg/issues/478

but there was this in 2018
https://github.com/w3c/svgwg/issues/424#issuecomment-408998878

Anyway, I have a patch, but still suspicious if it's the right thing to do.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240111/7a1ed4a3/attachment-0001.htm>