[Webkit-unassigned] [Bug 267167] New: Remove 'float:none' for computed value for Flex/Grid Items

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=267167

            Bug ID: 267167
           Summary: Remove 'float:none' for computed value for Flex/Grid
                    Items
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Keywords: BrowserCompat, WPTImpact
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: bfulgham at webkit.org, ntim at apple.com,
                    sgill26 at apple.com, simon.fraser at apple.com,
                    zalan at apple.com

Hi Team,

While looking into browser specific failures, I noted that we fail two tests:

https://wpt.fyi/results/css/css-display/display-with-float-dynamic.html?label=master&label=experimental&aligned&q=safari%3Afail

https://wpt.fyi/results/css/css-display/display-with-float.html?label=master&label=experimental&aligned=&q=safari%3Afail

> display-with-float-dynamic.html
> display-with-float.html

I noticed that we have computed value as 'None'. Looking into 'Blink' change, I noticed, we have also it in StyleAdjuster.cpp as 'None'.

Removing the line:

https://github.com/WebKit/WebKit/blob/fd569defc022c2d1e03658764ac31816e0267ef1/Source/WebCore/style/StyleAdjuster.cpp#L490

// https://www.w3.org/TR/css-display/#transformations
        // "A parent with a grid or flex display value blockifies the box’s display type."
        if (m_parentBoxStyle.isDisplayFlexibleOrGridBox()) {
            style.setFloating(Float::None);
            style.setEffectiveDisplay(equivalentBlockDisplay(style));
        }

to just:

// https://www.w3.org/TR/css-display/#transformations
        // "A parent with a grid or flex display value blockifies the box’s display type."
        if (m_parentBoxStyle.isDisplayFlexibleOrGridBox()) {
            style.setEffectiveDisplay(equivalentBlockDisplay(style));
        }

___

We start progressing above two tests. I haven't run whole 'css' (WPT suite) or other tests but just wanted to raise bug so we can track and fix it.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240106/6ed95a95/attachment.htm>