[Webkit-unassigned] [Bug 284738] New: [WebDriver][socket] fix issue that the capabilities.acceptInsecureCerts is always true

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=284738

            Bug ID: 284738
           Summary: [WebDriver][socket] fix issue that the
                    capabilities.acceptInsecureCerts is always true
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: New Bugs
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: haruhisa.shin at open-tec.co.jp

There was a mistake in https://commits.webkit.org/287707@main .

>    if (capabilitiesObject && capabilitiesObject->getBoolean("acceptInsecureCerts"_s))
>        capabilities.acceptInsecureCertificates = true;

The JSONObject::getBoolean() returns std::optional<bool>, not bool.
So the above code would set variable acceptInsecureCertificates  to true even if the JSON value is false.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20241216/ea9d1b77/attachment.htm>