[Webkit-unassigned] [Bug 284487] New: RenderText.isHorizontalWritingMode() returns incorrect value

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=284487

            Bug ID: 284487
           Summary: RenderText.isHorizontalWritingMode() returns incorrect
                    value
           Product: WebKit
           Version: WebKit Local Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: New Bugs
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: fantasai.bugs at inkedblade.net

Created attachment 473544

  --> https://bugs.webkit.org/attachment.cgi?id=473544&action=review

testcase with underlining and shadows

It seems like RenderText's StateFlag::VerticalWritingMode is not being set correctly, since we're painting text-decoration shadows using the horizontal mode offsets in TextDecorationPainter::paintBackgroundDecorations instead of the vertical ones. m_isHorizontal, which is set from TextBoxPainter's m_renderer.isHorizontalWritingMode() is true, while the WritingMode taken from RenderStyle is vertical.

A workaround for the attached testcase is to use the WritingMode directly, but the fact that StateFlag::VerticalWritingMode is set incorrectly means there's probably additional problems in other parts of the code.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20241211/504970ee/attachment-0001.htm>