[Webkit-unassigned] [Bug 284175] New: webkitscmpy.local.git.Git.commits strips all whitespace from end of commit message

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=284175

            Bug ID: 284175
           Summary: webkitscmpy.local.git.Git.commits strips all
                    whitespace from end of commit message
           Product: WebKit
           Version: Other
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: gsnedders at apple.com
                CC: bfan2 at apple.com, jbedard at apple.com,
                    webkit-bug-importer at group.apple.com

c.f. https://github.com/WebKit/WebKit/blob/d4f8ca8ffac838dd9db82dc67b830005a1d230e7/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py#L898

This is slightly surprising, as I would've expected the Commit message to just mirror what the repository actually has, blank lines, trailing whitespace, and all.

git doesn't in any way require Commit messages to end with new lines, they almost invariably do — and this is arguably problematic if you're taking the message and putting it into strict POSIX tools which expect a line to end with a new line.

It's unclear from the commit history what the motivation for this behaviour is, and notably while Git.commits does this, Git.commit does not, and that inconsistency seems especially bad.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20241206/ab52df4c/attachment.htm>