[Webkit-unassigned] [Bug 278906] misleading run-webkit-app in README and usage output

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 30 21:55:18 PDT 2024


https://bugs.webkit.org/show_bug.cgi?id=278906

--- Comment #2 from Chenfeng Pan <pancfmiaomiao at gmail.com> ---
(In reply to Alexey Proskuryakov from comment #1)
> Looks like `Tools/Scripts/run-webkit-app <application-path>` example is in
> the macOS section, so the fact that it works with iOS Simulator is
> undocumented.
> 
> So some of the improvements here are:
> 
> - Yes, need to add --debug to the example.
> 
> - Potentially document set-webkit-configuration, which is a way to avoid the
> need to pass --debug or --release all the time.
> 
> - Would be good to add that run-webkit-app works with the simulator (I
> assume that you verified that it actually successfully uses the locally
> built WebKit, and not the one from simulator runtime).
> 
> - Fix `run-webkit-app --help`. I'm not sure from the top of my head what
> --ios-simulator does as opposed to iPhone and iPad variants.
> 
> Would you be willing to post a PR with the improvements?

I have already tried ‘run-WebKit-app —-iPhone-simulator’ which comes from usage output, and only got an error indicating unknown option. I didn’t try —-ipad-simulator option, but I guess the same result. So I think the usage definitely needs update.

And yeah,I will post a PR with the necessary improvements.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240831/6051de1b/attachment-0001.htm>


More information about the webkit-unassigned mailing list