[Webkit-unassigned] [Bug 278785] New: REGRESSION(281966 at main): [Win] `PageClient::didPerformDragOperation()` is never called

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=278785

            Bug ID: 278785
           Summary: REGRESSION(281966 at main): [Win]
                    `PageClient::didPerformDragOperation()` is never
                    called
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: New Bugs
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: vitaly at igalia.com

Before 281966 at main

```
void WebPageProxy::performDragOperation(DragData& dragData, const String& dragStorageName, SandboxExtension::Handle&& sandboxExtensionHandle, Vector<SandboxExtension::Handle>&& sandboxExtensionsForUpload)
{
#if PLATFORM(COCOA)
    grantAccessToCurrentPasteboardData(dragStorageName);
#endif

#if PLATFORM(GTK)
    performDragControllerAction(DragControllerAction::PerformDragOperation, dragData);
#else
    if (!hasRunningProcess())
        return;

    sendWithAsyncReply(Messages::WebPage::PerformDragOperation(dragData, WTFMove(sandboxExtensionHandle), WTFMove(sandboxExtensionsForUpload)), [this, protectedThis = Ref { *this }] (bool handled) {
        protectedPageClient()->didPerformDragOperation(handled);
    });
#endif
}
```

after

```
void WebPageProxy::performDragOperation(DragData& dragData, const String& dragStorageName, SandboxExtension::Handle&& sandboxExtensionHandle, Vector<SandboxExtension::Handle>&& sandboxExtensionsForUpload)
{

#if PLATFORM(GTK)
    performDragControllerAction(DragControllerAction::PerformDragOperation, dragData);
#endif
#if PLATFORM(COCOA)
    if (!hasRunningProcess())
        return;
    grantAccessToCurrentPasteboardData(dragStorageName, [this, protectedThis = Ref { *this }, dragStorageName, dragData = WTFMove(dragData), sandboxExtensionHandle = WTFMove(sandboxExtensionHandle), sandboxExtensionsForUpload = WTFMove(sandboxExtensionsForUpload)] () mutable {
        sendWithAsyncReply(Messages::WebPage::PerformDragOperation(dragData, WTFMove(sandboxExtensionHandle), WTFMove(sandboxExtensionsForUpload)), [this, protectedThis = Ref { *this }] (bool handled) {
            protectedPageClient()->didPerformDragOperation(handled);
        });
    });
#endif
}
```

Note missing #else directive.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240828/db9c4d98/attachment.htm>