[Webkit-unassigned] [Bug 278503] New: WPT linter should by run by check-webkit-style

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 21 18:03:45 PDT 2024


https://bugs.webkit.org/show_bug.cgi?id=278503

            Bug ID: 278503
           Summary: WPT linter should by run by check-webkit-style
           Product: WebKit
           Version: Other
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: simon.fraser at apple.com

I added some WPT tests a few commits ago. But when I later try to export them, the linter finds some errors:

ERROR:lint:css/css-backgrounds/background-clip/clip-text-text-decorations-ref.html: Don't use Ahem as a system font, use /fonts/ahem.css (AHEM SYSTEM FONT)
ERROR:lint:css/css-backgrounds/background-clip/clip-text-text-decorations.html: Don't use Ahem as a system font, use /fonts/ahem.css (AHEM SYSTEM FONT)
INFO:lint:
INFO:lint:There were 2 errors (AHEM SYSTEM FONT: 2)
INFO:lint:You must fix all errors; for details on how to fix them, see
INFO:lint:https://web-platform-tests.org/writing-tests/lint-tool.html
INFO:lint:
INFO:lint:However, instead of fixing a particular error, it's sometimes
INFO:lint:OK to add a line to the lint.ignore file in the root of the
INFO:lint:web-platform-tests directory to make the lint tool ignore it.
INFO:lint:
INFO:lint:For example, to make the lint tool ignore all 'AHEM SYSTEM FONT'
INFO:lint:errors in the css/css-backgrounds/background-clip/clip-text-text-decorations.html file,
INFO:lint:you could add the following line to the lint.ignore file.
INFO:lint:
INFO:lint:AHEM SYSTEM FONT: css/css-backgrounds/background-clip/clip-text-text-decorations.html
ERROR: The wpt linter detected 2 linting error(s). Please address the above errors before attempting to export changes to the web-platform-test repository.

This means I can't directly export those WPT to the wpt repo; I'll have to make a PR by hand.

Ideally these errors would have been caught at `git webkit pr` time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240822/76c39a34/attachment.htm>


More information about the webkit-unassigned mailing list