[Webkit-unassigned] [Bug 278260] New: ENABLE_MALLOC_HEAP_BREAKDOWN has compilation problems when turned on

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=278260

            Bug ID: 278260
           Summary: ENABLE_MALLOC_HEAP_BREAKDOWN has compilation problems
                    when turned on
           Product: WebKit
           Version: WebKit Local Build
          Hardware: Unspecified
                OS: macOS 15
            Status: NEW
          Severity: Minor
          Priority: P2
         Component: WebCore Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: nathan_solomon at apple.com

Summary:
When turning on ENABLE_MALLOC_HEAP_BREAKDOWN, Webkit fails to compile and has many errors.

Steps To Reproduce:
1. Set ENABLE_MALLOC_HEAP_BREAKDOWN to 1 (/OpenSource/WebKitBuild/Debug/usr/local/include/wtf/PlatformEnable.h)
2. Set BENABLE_MALLOC_HEAP_BREAKDOWN to 1 (/OpenSource/Source/bmalloc/bmalloc/BPlatform.h)
Compile with make d | filter-build-webkit

Results:
Here are some of the compiler errors:

In file included from /Users/nathansolomon/workspace/OpenSource/WebKitBuild/Debug/DerivedSources/WebCore/unified-sources/UnifiedSource105.cpp:3:
/Users/nathansolomon/workspace/OpenSource/Source/WebCore/animation/FrameRateAligner.cpp:30:1: error: use of undeclared identifier 'FrameRateAlignerMalloc'; did you mean 'FrameRateAligner'?
  30 | DEFINE_ALLOCATOR_WITH_HEAP_IDENTIFIER(FrameRateAligner);
In file included from /Users/nathansolomon/workspace/OpenSource/WebKitBuild/Debug/DerivedSources/WebCore/unified-sources/UnifiedSource105.cpp:1:
In file included from /Users/nathansolomon/workspace/OpenSource/Source/WebCore/WebCorePrefix.h:164:
In file included from /Users/nathansolomon/workspace/OpenSource/WebKitBuild/Debug/usr/local/include/wtf/FastMalloc.h:25:
/Users/nathansolomon/workspace/OpenSource/WebKitBuild/Debug/usr/local/include/wtf/DebugHeap.h:81:21: note: expanded from macro 'DEFINE_ALLOCATOR_WITH_HEAP_IDENTIFIER'
  81 |   WTF::DebugHeap& Type##Malloc::debugHeap() \
<scratch space>:180:1: note: expanded from here
 180 | FrameRateAlignerMalloc
And more.

Most are related to a missing DECLARE_ALLOCATOR_WITH_HEAP_IDENTIFIER statement and due to a missing #include "AnimationMalloc.h” in AcceleratedTimeLine.h

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240816/782eb2bf/attachment.htm>