[Webkit-unassigned] [Bug 277657] New: Remove the indirection in isMouseFocusable() to call directly the quirk

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=277657

            Bug ID: 277657
           Summary: Remove the indirection in isMouseFocusable() to call
                    directly the quirk
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Keywords: GoodFirstBug
          Severity: Normal
          Priority: P4
         Component: WebKit Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: karlcow at apple.com
                CC: webkit-bug-importer at group.apple.com

On https://searchfox.org/wubkat/rev/b36cbce69fddb7da33823f316bd8ead5bebee970/Source/WebCore/html/HTMLFormControlElement.cpp#492

there is 

```
// FIXME: We should remove the quirk once <rdar://problem/47334655> is fixed.
bool HTMLFormControlElement::needsMouseFocusableQuirk() const
{
    return document().quirks().needsFormControlToBeMouseFocusable();
}
```


which is used in https://searchfox.org/wubkat/rev/b36cbce69fddb7da33823f316bd8ead5bebee970/Source/WebCore/html/HTMLFormControlElement.cpp#251-260


```
bool HTMLFormControlElement::isMouseFocusable() const
{
#if (PLATFORM(GTK) || PLATFORM(WPE))
    return HTMLElement::isMouseFocusable();
#else
    if (!!tabIndexSetExplicitly() || needsMouseFocusableQuirk())
        return HTMLElement::isMouseFocusable();
    return false;
#endif
}
```


it doesn't need the indirection. 


1. The function should isMouseFocusable() should directly call document().quirks().needsFormControlToBeMouseFocusable()
2. Do not forget about moving the comment too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240805/df5cde28/attachment.htm>