[Webkit-unassigned] [Bug 277654] New: run-webkit-tests exit code shouldn't depend on number of unexpected results

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 5 16:12:25 PDT 2024


https://bugs.webkit.org/show_bug.cgi?id=277654

            Bug ID: 277654
           Summary: run-webkit-tests exit code shouldn't depend on number
                    of unexpected results
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: gsnedders at apple.com
                CC: aakash_jain at apple.com, jbedard at apple.com,
                    webkit-bug-importer at group.apple.com

Currently, if we get the expected output but exit with non-zero, EWS will totally ignore this: https://github.com/WebKit/WebKit/blob/e9e196408b4460466726b2ac2f42e709e559e764/Tools/CISupport/ews-build/steps.py#L4113-L4114

We practically have to do this, because the exit code is actually just the number of regressions: https://github.com/WebKit/WebKit/blob/e9e196408b4460466726b2ac2f42e709e559e764/Tools/Scripts/webkitpy/port/base.py#L961-L966

It would be probably be better to define an exit code which means "we had regressions", as we then don't end up in situations where a single exit code can mean multiple things.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240805/f0994955/attachment.htm>


More information about the webkit-unassigned mailing list