[Webkit-unassigned] [Bug 273315] New: [CMake] Skia headers symlink is sometimes not created before it is needed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 26 04:55:48 PDT 2024


https://bugs.webkit.org/show_bug.cgi?id=273315

            Bug ID: 273315
           Summary: [CMake] Skia headers symlink is sometimes not created
                    before it is needed
           Product: WebKit
           Version: WebKit Local Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: aperez at igalia.com

Building .o files does not need libSkia.a, and the headers symlink is created
as side effect of generating libSkia.a; so we can end up in situations where
sources need to include the Skia headers but the symlink wasn't yet created.

For example in this build log:

  https://ews-build.webkit.org/#/builders/5/builds/52139/steps/14/logs/stdio

This is more obvious after bug #270776 but could have happened before that,
we were just lucky that as a custom_target() without dependencies Ninja/Make
were scheduling symlink creation very early during the build.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240426/21d7b0a7/attachment.htm>


More information about the webkit-unassigned mailing list