[Webkit-unassigned] [Bug 273097] [GTK] MessageSender.h:83:18: error: ‘virtual bool IPC::MessageSender::sendMessage(WTF::UniqueRef<IPC::Encoder>&&, WTF::OptionSet<IPC::SendOption>)’ was hidden [-Werror=overloaded-virtual=]

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=273097

Claudio Saavedra <csaavedra at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |csaavedra at igalia.com

--- Comment #1 from Claudio Saavedra <csaavedra at igalia.com> ---
Is it possible that this is caused by unified builds? I can't reproduce this by building WKGTK from directly from git, but when I build a couple of my own MRs, I hit this locally.

IIUC we have

 virtual bool MessageSender::sendMessage(UniqueRef<Encoder>&&, OptionSet<SendOption>);

and then

 template<typename T> void WebSocketChannel::sendMessage(T&&, size_t byteLength);

pulled into the same compilation unit. WebSocketChannel inherits from MessageSender:

  class WebSocketChannel : public IPC::MessageSender, public IPC::MessageReceiver, public WebCore::ThreadableWebSocketChannel, public RefCounted<WebSocketChannel> {


Is this intentional?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240423/6c389a4d/attachment.htm>