[Webkit-unassigned] [Bug 270079] PlayCanvas WebGPU examples failed to run

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 11 09:41:22 PDT 2024


https://bugs.webkit.org/show_bug.cgi?id=270079

--- Comment #13 from Mike Wyrzykowski <mwyrzykowski at apple.com> ---
Oh that's right we do support 32 byte alignment, I was looking at non-Apple silicon Macs which are limited to 256 byte alignment in WebKit. 

Is PlayCanvas requesting 32 byte alignment in its call to GPUAdapter.requestDevice()?

I tried logging the limits from the web process:
% git diff
diff --git a/Source/WebCore/Modules/WebGPU/GPUAdapter.cpp b/Source/WebCore/Modules/WebGPU/GPUAdapter.cpp
index b626e3eac2b2..d5807b80d552 100644
--- a/Source/WebCore/Modules/WebGPU/GPUAdapter.cpp
+++ b/Source/WebCore/Modules/WebGPU/GPUAdapter.cpp
@@ -109,6 +109,10 @@ void GPUAdapter::requestDevice(ScriptExecutionContext& scriptExecutionContext, c
         return;
     }

+    if (deviceDescriptor) {
+        for (auto& [key,value] : deviceDescriptor->requiredLimits)
+            WTFLogAlways("%s, %llu", key.utf8().data(), value);
+    }
     m_backing->requestDevice(convertToBacking(deviceDescriptor), [deviceDescriptor, promise = WTFMove(promise), scriptExecutionContextRef = Ref { scriptExecutionContext }](RefPtr<WebGPU::Device>&& device) mutable {
         if (!device.get())
             promise.reject(Exception(ExceptionCode::OperationError));


but I don't see PlayCanvas requesting requiredLimits: https://www.w3.org/TR/webgpu/#dom-gpudevicedescriptor-requiredlimits


It's very possible we are failing conversion however

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240411/16ad6f65/attachment.htm>


More information about the webkit-unassigned mailing list