[Webkit-unassigned] [Bug 272222] New: Fix incorrect EGL function type definitions in PlatformDisplay

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 5 06:47:53 PDT 2024


https://bugs.webkit.org/show_bug.cgi?id=272222

            Bug ID: 272222
           Summary: Fix incorrect EGL function type definitions in
                    PlatformDisplay
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Platform
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: aperez at igalia.com

The “Source/WebCore/platform/graphics/PlatformDisplay.cpp” contains a few
definitions of EGL extension function types (PFN??PROC) which look like this:

  #if !defined(PFNEGLDESTROYIMAGEPROC)
  typedef EGLBoolean (*PFNEGLDESTROYIMAGEPROC) (EGLDisplay, EGLImage);
  #endif

  #if !defined(PFNEGLCREATEIMAGEKHRPROC)
  typedef EGLImageKHR (*PFNEGLCREATEIMAGEKHRPROC) (EGLDisplay, EGLContext, EGLenum target, EGLClientBuffer, const EGLint* attribList);
  #endif

These are missing usage of the “EGLAPIENTRYP” macro. Also, the PFN??PROC are
type definitions and not macros in the EGL headers so these will be always
defined even if already present, instead we should gate their definition
either on the extension name macro i.e. defined(EGL_KHR_image_base), or on
the EGL version macro i.e. defined(EGL_VERSION_1_5).

With the outlined changes then the definitions would compliant with the
EGL specifications, and coherent with what is done elsewhere in WebKit.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240405/478d47b0/attachment.htm>


More information about the webkit-unassigned mailing list