[Webkit-unassigned] [Bug 271610] Web Inspector: Generating JS builtins for createInspectorInjectedScript is very slow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=271610

--- Comment #11 from Karl Dubost <karlcow at apple.com> ---
timing the different regex inside 

BuiltinFunction.fromString

% python3 Source/JavaScriptCore/Scripts/generate-js-builtins.py --framework JavaScriptCore --output-directory /tmp/ --combined Source/JavaScriptCore/inspector/InjectedScriptSource.js


--------
Inside fromString
multilineCommentRegExp: 0.00000183s
functionIntrinsicRegExp: 0.00029496s
functionOverriddenNameRegExp: 0.00030350s
functionNameRegExp: 0.00000129s
function_name: createObjectWithoutPrototype
functionVisibilityRegExp: 0.00030337s
--------
Inside fromString
multilineCommentRegExp: 0.00000067s
functionIntrinsicRegExp: 0.00011783s
functionOverriddenNameRegExp: 0.00011892s
functionNameRegExp: 0.00000079s
function_name: createArrayWithoutPrototype
functionVisibilityRegExp: 0.00011775s
--------
Inside fromString
multilineCommentRegExp: 0.00001742s
functionIntrinsicRegExp: 7.45201550s
functionOverriddenNameRegExp: 5.22347075s
functionNameRegExp: 0.00006025s
function_name: createInspectorInjectedScript
functionVisibilityRegExp: 0.00018467s

how long for BuiltinFunction.fromString: 17.81850321s


These are the two RegExp which are not performant.
functionIntrinsicRegExp: 7.45201550s
functionOverriddenNameRegExp: 5.22347075s


functionIntrinsicRegExp = re.compile(r".*^@intrinsic=(\w+)", re.MULTILINE | re.DOTALL)
functionOverriddenNameRegExp = re.compile(r".*^@overriddenName=(\".+\")$", re.MULTILINE | re.DOTALL)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240403/973bad4b/attachment.htm>