[Webkit-unassigned] [Bug 271977] New: REGRESSION (276827 at main): When drawing a pattern, get the oriented image frame only if the orientation is not TopLeft

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=271977

            Bug ID: 271977
           Summary: REGRESSION (276827 at main): When drawing a pattern, get
                    the oriented image frame only if the orientation is
                    not TopLeft
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Images
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: sabouhallawa at apple.com
                CC: sabouhallawa at apple.com

BitmapImage::drawPattern() uses ImageOrientation::Orientation::FromImage when using the current ImageFrame to draw the pattern. We end up calling BitmapImageSource::preTransformedNativeImageAtIndex() via other calls. After 276827 at main, this function checks

if (orientation == ImageOrientation::Orientation::None && size == sourceSize)
    return nativeImage;

Before resolving the orientation if FromImage is passed. We then resolve the image orientation.

if (orientation == ImageOrientation::Orientation::FromImage)
    orientation = frameOrientationAtIndex(index);

We then draw the current ImageFrame to a temporary ImageBuffer then we sink the drawn the ImageBuffer to a new NativeImage. This step is not needed if image orientation is TopLeft. We can just return the original image frame.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240401/4cd0138b/attachment.htm>