[Webkit-unassigned] [Bug 260771] REGRESSION(2.42): PDF "Save" button does nothing, "Print" function also broken

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=260771

Michael Catanzaro <mcatanzaro at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |annevk at annevk.nl

--- Comment #4 from Michael Catanzaro <mcatanzaro at redhat.com> ---
Well I found the commit to blame. We're going to have to think about how to handle this.

b1a659b38f09d05fd3e7b3b112066894ab099b8c is the first bad commit
commit b1a659b38f09d05fd3e7b3b112066894ab099b8c
Author: Anne van Kesteren <annevk at annevk.nl>
Date:   Mon Jul 24 08:42:00 2023 -0700

    Return opaque origin for blob: URL containing inner non-http(s): URL
    https://bugs.webkit.org/show_bug.cgi?id=257262
    rdar://109781193

    Reviewed by Alex Christensen and Darin Adler.

    Refactor SecurityOrigin so it is more clear blob: URLs are the sole
    special case. And change how we derive the blob: URL origin to align
    with the URL standard:

    * No longer perform percent-decoding (matches other browsers).
    * Restrict non-opaque origins to HTTP(S) URLs (will soon match other
      browsers). However:

      * Still give blob: URLs derived from file: origins an origin for now
        as removing that ability needs a bit more care. This currently goes
        against the URL standard, but that might change.
      * Also give registered schemes a pass to allow embedders to continue
        to use blob: URLs as they see fit.

    Also change BlobURL to rely more directly on SecurityOrigin.

    * LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-expected.txt:
    * LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-xhtml-expected.txt:
    * LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any-expected.txt:
    * LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any.worker-expected.txt:
    * Source/WebCore/fileapi/BlobURL.cpp:
    (WebCore::BlobURL::getOriginURL):
    (WebCore::BlobURL::isSecureBlobURL):
    * Source/WebCore/fileapi/ThreadableBlobRegistry.cpp:
    (WebCore::ThreadableBlobRegistry::getCachedOrigin):
    * Source/WebCore/page/SecurityOrigin.cpp:
    (WebCore::SecurityOrigin::create):
    (WebCore::SecurityOrigin::forBlobURL):
    (WebCore::SecurityOrigin::isSecure):
    (WebCore::SecurityOrigin::shouldUseInnerURL): Deleted.
    (WebCore::SecurityOrigin::extractInnerURL): Deleted.
    * Source/WebCore/page/SecurityOrigin.h:
    * Source/WebCore/page/SecurityOriginData.cpp:
    (WebCore::SecurityOriginData::shouldTreatAsOpaqueOrigin):

    Canonical link: https://commits.webkit.org/266247@main

 .../url/a-element-origin-expected.txt              | 10 ++--
 .../url/a-element-origin-xhtml-expected.txt        | 10 ++--
 .../url/url-origin.any-expected.txt                | 10 ++--
 .../url/url-origin.any.worker-expected.txt         | 10 ++--
 Source/WebCore/fileapi/BlobURL.cpp                 | 14 ++----
 Source/WebCore/fileapi/ThreadableBlobRegistry.cpp  |  3 +-
 Source/WebCore/page/SecurityOrigin.cpp             | 57 ++++++++++++----------
 Source/WebCore/page/SecurityOrigin.h               | 18 ++-----
 Source/WebCore/page/SecurityOriginData.cpp         | 13 ++---
 9 files changed, 66 insertions(+), 79 deletions(-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230928/650fa3ba/attachment-0001.htm>