[Webkit-unassigned] [Bug 261986] New: [CSS-Sizing] Block size with max-content and min-content in a table

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=261986

            Bug ID: 261986
           Summary: [CSS-Sizing] Block size with max-content and
                    min-content in a table
           Product: WebKit
           Version: Safari Technology Preview
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Keywords: BrowserCompat, WPTImpact
          Severity: Normal
          Priority: P2
         Component: CSS
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: karlcow at apple.com, ntim at apple.com

Hi Team,

While going through Blink's commit, I came across fix for two failing WPT in CSS-Sizing:

Link: http://wpt.live/css/css-sizing/block-size-with-min-or-max-content-table-1b.html & http://wpt.live/css/css-sizing/block-size-with-min-or-max-content-table-1a.html

Blink Commit - https://chromium.googlesource.com/chromium/src.git/+/3a0c4adda19bade345ca115fdcfe825acf0b8869

^ Only doing partial merge of 'RenderTable.cpp', make us pass above two tests in my local build.

Line 532:

if (logicalMaxHeightLength.isFillAvailable() || (logicalMaxHeightLength.isSpecified() && !logicalMaxHeightLength.isNegative() && !logicalMaxHeightLength.isMinContent() && !logicalMaxHeightLength.isMaxContent() && !logicalMaxHeightLength.isFitContent()))

Line 538 (new to add):

if (logicalMinHeightLength.isMinContent() || logicalMinHeightLength.isMaxContent() || logicalMinHeightLength.isFitContent())
            logicalMinHeightLength = LengthType::Auto;

___

I have this patch in local since long and haven't had any issue.

Just raising so I can fix it later. Adding 'BrowserCompat' since only Safari / WebKit is failing these tests and 'WPTImpact' tag due to tests being on WPT.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230923/5bd8ec46/attachment.htm>