[Webkit-unassigned] [Bug 261960] New: Create a combine GTK/WPE PlatformEnablement file

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 22 11:07:03 PDT 2023


            Bug ID: 261960
           Summary: Create a combine GTK/WPE PlatformEnablement file
           Product: WebKit
           Version: WebKit Local Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: bfulgham at webkit.org
                CC: webkit-bug-importer at group.apple.com

The design of the build enablement flags is for PlatformEnable.h to contain the default state of flags, and for individual ports to have specific files that control the state on those platforms (assuming they do not want the default behavior).

In general, features should start of enabled in some ports and not others, then be enabled on all ports, then eventually the compile option is removed and all ports just build it all the time.

We have dedicated files for Playstation, Cocoa, and Windows, but the GTK/WPE port flags live inside the main PlatformEnable header, leading to confusion and encouraging developers to add more conditional flags in that "default" file.

This patch adds a new PlatformEnableGTKWPE.h file that moves the relevant flags, and tidies up the primary file.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230922/1971cc7e/attachment.htm>

More information about the webkit-unassigned mailing list