[Webkit-unassigned] [Bug 261712] Add https://searchfox.org/wubkat/source/ “Search the WebKit sources” link somewhere

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=261712

Diego Pino <dpino at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dpino at igalia.com

--- Comment #6 from Diego Pino <dpino at igalia.com> ---
The main difference is that Searchfox builds the source code while GitHhub doesn't. My understanding is that GitHub only supports textual search, which Searchfox also supports through livegrep.

Building the sources allows Searchfox to build a dictionary of symbols. That allows symbol highlighting and symbol navigation. Also, since the source code is built searches include generated files.

Searchfox also provides blame information per line of code. Hovering on the left side of a file shows a popup window with blame information. It wouldn't be hard to tune that pop-up window to show a 'Show bug' link or a link to the corresponding GitHub pull-request.

Lastly, notice that the WebKit setup of Searchfox builds WebKitGTK with certain settings (https://github.com/mozsearch/mozsearch-mozilla/blob/master/wubkat/build#L45). That means that code paths or files that depend on having certain features enabled won't be compiled, that means there's no symbol highlighting or symbol navigation for those files or code paths. The same applies for port specific files other than WebKitGTK.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230920/3bcf7468/attachment.htm>