[Webkit-unassigned] [Bug 261680] AX: columnHeaders() and rowHeaders() are performed on the main thread in ITM

Mon Sep 18 19:43:50 PDT 2023

https://bugs.webkit.org/show_bug.cgi?id=261680

--- Comment #4 from Joshua Hoffman <jhoffman23 at apple.com> ---
Comment on attachment 467739
  --> https://bugs.webkit.org/attachment.cgi?id=467739
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467739&action=review

>> Source/WebCore/accessibility/AccessibilityObjectInterface.h:1789
>> +        if (parent->roleValue() == AccessibilityRole::RowGroup)
> 
> This is a behavior change relative to what this function used to do (compare thead, tbody, or tfoot ancestors). Maybe we need a new AXID property and virtual function called row-group container which we cache for table-cells only and compare here?

Sounds good, let's do that instead!

>> Source/WebCore/accessibility/AccessibilityTableRow.h:44
>> +    AXCoreObject* headerObject() override;
> 
> Can this be final?

This one can't because it can be overridden by AccessibilityARIAGridRow, but I'll mark that one as final.

>> Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:167
>> +    String scope() const override { return stringAttributeValue(AXPropertyName::Scope); }
> 
> Can these be final?

Yep, that was an oversight on my part

>> LayoutTests/accessibility/column-header-scope.html:21
>> +	</table>
> 
> Seems like a lot of lines in this test have 8 space indents — I think we've been trying to stick with 4. Also, I think we typically don't indent after the <body>. So like this:
> 
> <body>
> <table>
>     ....
> </table>
> <script>
> ...
> </script>

will update that along with the other style suggestions!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230919/256bd867/attachment.htm>